Refactor a bit #23
Merged
Refactor a bit #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
===========================================
+ Coverage 56.42% 84.05% +27.63%
===========================================
Files 11 12 +1
Lines 514 508 -6
===========================================
+ Hits 290 427 +137
+ Misses 224 81 -143 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This makes the code a bit easier to follow.
Changes
Introduce a
CondaDenyConfigstruct that contains all configuration and is generated at the beginning from CLI + config.toml.We can then pass this struct to all methods that need it instead of needing to handle config parsing and evaluating everywhere.
With this, there are three config structs: the toml, the cli as well as the final config that is used in the business logic. The toml and cli configs are used at the beginning exclusively to generate the main config struct.